Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{lib}[GCCcore/10.2.0,GCCcore/12.2.0] json-fortran v8.3.0 #17994

Merged

Conversation

SimonPinches
Copy link
Contributor

(created using eb --new-pr)

@SimonPinches
Copy link
Contributor Author

I've kept the EB file and module names the same as the existing one but would personally have preferred to call them JSON-Fortran as used in the developer's README.

@SimonPinches
Copy link
Contributor Author

Note depending upon the version of pkg-config you use, it may be necessary to install usign the --filter-env-vars=CPATH flag to overcome the problem described in easybuilders/easybuild-framework#3331.

@verdurin
Copy link
Member

@boegelbot please test @ generoso

@verdurin
Copy link
Member

Test report by @verdurin
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
easybuild-c7.novalocal - Linux CentOS Linux 7.9.2009, x86_64, Intel Xeon Processor (Skylake, IBRS), Python 3.6.8
See https://gist.github.com/verdurin/074f3fc04a7604c287bf050617d36fbe for a full test report.

@boegelbot
Copy link
Collaborator

@verdurin: Request for testing this PR well received on login1

PR test command 'EB_PR=17994 EB_ARGS= EB_CONTAINER= /opt/software/slurm/bin/sbatch --job-name test_PR_17994 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 11014

Test results coming soon (I hope)...

- notification for comment with ID 1595197043 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3ded048fa3a4bfe11229341190059862 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

This has fortran code, this should be at GCC level if it is producing fortran modules to be consumed.

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

I've updated the easyconfigs upstream to reflect this: #19283

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

Ah, you actually made the correction here (apart from removing the versions that already existed upstream)!

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

@SimonPinches I would agree with you that we should have used JSON-Fortran when naming this. If you have the appetite to do rename PR, I would be open to reviewing it

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@ocaisa: Request for testing this PR well received on login1

PR test command 'EB_PR=17994 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_17994 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12218

Test results coming soon (I hope)...

- notification for comment with ID 1822807603 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

@boegelbot please test @ jsc-zen2

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 3 out of 4 (4 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/c88ecbc47393a94e476ea434b8463503 for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

@SimonPinches There's no licence file for the older intel compilers on generoso, can you submit a test report?

@branfosj
Copy link
Member

Test report by @branfosj
SUCCESS
Build succeeded for 5 out of 5 (4 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/a23dd256cd0e2a0f867ae12263f4aaea for a full test report.

@ocaisa
Copy link
Member

ocaisa commented Nov 22, 2023

Thanks @branfosj , that's enough for me!

@ocaisa ocaisa merged commit 6ffd6ab into easybuilders:develop Nov 22, 2023
9 checks passed
@branfosj
Copy link
Member

@boegelbot please test @ generoso

@boegel boegel added the update label Nov 22, 2023
@boegel boegel added this to the next release (4.9.0?) milestone Nov 22, 2023
@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17994 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_17994 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12227

Test results coming soon (I hope)...

- notification for comment with ID 1823011990 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@branfosj: Request for testing this PR well received on login1

PR test command 'EB_PR=17994 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_17994 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12228

Test results coming soon (I hope)...

- notification for comment with ID 1823101085 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
cns2 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/206f44f473e30c6673c0832ebef23a61 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants