Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for auth module #459

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Tests for auth module #459

wants to merge 1 commit into from

Conversation

lwasser
Copy link

@lwasser lwasser commented Nov 20, 2021

UPDATE: this is good to go for a review. all functions are now covered via tests and i did some cleanup on the test suite itself and added lots of notes about process. There are a few fixtures that i think i can simplify by creating a fixture helper function and then separate small fixtures.

i will come back and work on that later maybe after the review even depending on timing. but this is ready for a solid look!

this will address some of #361 #194

TODO:

UPDATE: i believe that i can globally patch if i move to an object oriented test suite -

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #459 (8c3321b) into main (54f4b3c) will increase coverage by 8.74%.
The diff coverage is 100.00%.

❗ Current head 8c3321b differs from pull request most recent head c380810. Consider uploading reports for the commit c380810 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #459      +/-   ##
==========================================
+ Coverage   60.46%   69.20%   +8.74%     
==========================================
  Files          20       21       +1     
  Lines        1171     1302     +131     
==========================================
+ Hits          708      901     +193     
+ Misses        463      401      -62     
Flag Coverage Δ
unittests 69.20% <100.00%> (+8.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
abcclassroom/auth.py 100.00% <100.00%> (+86.11%) ⬆️
abcclassroom/tests/test_auth.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f4b3c...c380810. Read the comment docs.

@lwasser
Copy link
Author

lwasser commented Nov 22, 2021

ok team! we are at 100% coverage for the auth module. I had done most of the work. there is a failure happening on one of the tests that i am not sure relates to this but i'll look into it as it's come up twice now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant