Use pthread_exit to terminate raft service. #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow the process to handle termination of raft service rather than force process wide `exit()` Addresses eBay#535
|
I dunno if this should have a compile/runtime condition around it similar to: #ifdef USE_PTHREAD_EXIT
pthread_exit(nullptr);
#else
exit(-1)
#endifto avoid behavior change for those relying on this? |
|
Does it work correctly on Mac? I believe it doesn't work at least on Windows. We should write a helper function that works differently according to compiler flag, as you mentioned. |
It definitely doesn't work on Windows; but should on Mac...Mac has |
szmyd
force-pushed
the
use_pthread_exit
branch
from
770268e
to
abd919b
Compare
greensky00
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the process to handle termination of raft service rather than force process wide
exit()Addresses #535