Reduce system call #175
Reduce system call #175
Conversation
ZZhongge
commented
Sep 19, 2024
ZZhongge
commented
- for log manifest, remove truncate if the previous size is smaller.
- for backup log manifest, not open and close file in each call.
1. for log manifest, remove truncate if the previous size is smaller. 2. for backup log manifest, not open and close file in each call.
src/internal_helper.cc
Outdated
| std::string dst_file = filename + ".bak"; | ||
|
|
||
| try { | ||
| if (!f_ops->exist(dst_file)) { |
There was a problem hiding this comment.
Shall we need to check whether the file exist in each call? I tested it and even if the file is removed, all system call will success, but no file is persisted.
There was a problem hiding this comment.
Do you mean if dst_file does not exist, but *file != nullptr, all below pwrite succeeds, but nothing is written? Then yes.
There was a problem hiding this comment.
Yes. So, shall we need to rebuild the *file pointer here? Or we can ignore this case?
There was a problem hiding this comment.
Yes we should, otherwise backup won't be working.
src/internal_helper.cc
Outdated
| f_ops->fsync(*file); | ||
| } | ||
| return s; | ||
| } catch (Status s) { |
There was a problem hiding this comment.
Should be 4 spaces, currently 3.
| *file = nullptr; | ||
| } | ||
| return s; | ||
| } |
src/internal_helper.cc
Outdated
| std::string dst_file = filename + ".bak"; | ||
|
|
||
| try { | ||
| if (!f_ops->exist(dst_file)) { |
There was a problem hiding this comment.
Do you mean if dst_file does not exist, but *file != nullptr, all below pwrite succeeds, but nothing is written? Then yes.
src/internal_helper.cc
Outdated
| ctx.data + bytes_to_skip, | ||
| length - bytes_to_skip, | ||
| bytes_to_skip ) ); |
