Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build matrix for tooling. #46

Merged
merged 3 commits into from
Aug 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/build_commit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ on:
prerelease:
required: true
type: string
tooling:
required: true
type: string

jobs:
SislDeps:
Expand All @@ -25,7 +28,9 @@ jobs:
build-type: ${{ inputs.build-type }}
malloc-impl: ${{ inputs.malloc-impl }}
prerelease: ${{ inputs.prerelease }}
tooling: None
if: ${{ github.event_name != 'pull_request' }}

IOMgrDeps:
needs: SislDeps
uses: ./.github/workflows/build_dependencies.yml
Expand All @@ -35,8 +40,10 @@ jobs:
build-type: ${{ inputs.build-type }}
malloc-impl: ${{ inputs.malloc-impl }}
prerelease: ${{ inputs.prerelease }}
tooling: ${{ inputs.tooling }}
testing: 'True'
if: ${{ github.event_name != 'pull_request' }}

IOMgrBuild:
uses: ./.github/workflows/build_dependencies.yml
with:
Expand All @@ -45,5 +52,6 @@ jobs:
build-type: ${{ inputs.build-type }}
malloc-impl: ${{ inputs.malloc-impl }}
prerelease: ${{ inputs.prerelease }}
tooling: ${{ inputs.tooling }}
testing: 'True'
if: ${{ github.event_name == 'pull_request' }}
44 changes: 28 additions & 16 deletions .github/workflows/build_dependencies.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ on:
prerelease:
required: true
type: string
tooling:
required: false
type: string
default: 'None'
testing:
required: false
type: string
Expand Down Expand Up @@ -60,6 +64,13 @@ on:
- 'True'
- 'False'
default: 'False'
tooling:
required: false
type: choice
- 'Sanitize'
- 'Coverage'
- 'None'
default: 'None'
testing:
description: 'Build and Run'
required: true
Expand Down Expand Up @@ -135,7 +146,7 @@ jobs:
-o sisl:prerelease=${{ inputs.prerelease }} \
-o sisl:malloc_impl=${{ inputs.malloc-impl }} \
-o sisl:testing=False \
-o iomgr:testing=off \
-o testing=off \
-s build_type=${{ inputs.build-type }} \
--build missing \
.
Expand All @@ -156,6 +167,20 @@ jobs:
fail_on_cache_miss: true
if: ${{ inputs.testing == 'True' && github.event_name != 'pull_request' && steps.restore-cache.outputs.cache-hit != 'true' }}

- name: Create and Test Package
run: |
sanitize=$([[ "${{ inputs.tooling }}" == "Sanitize" ]] && echo "True" || echo "False")
conan create \
-o sisl:prerelease=${{ inputs.prerelease }} \
-o sisl:malloc_impl=${{ inputs.malloc-impl }} \
-o sisl:testing=False \
-o iomgr:sanitize=${sanitize} \
-o iomgr:testing='epoll_mode' \
-s build_type=${{ inputs.build-type }} \
--build missing \
.
if: ${{ inputs.testing == 'True' && inputs.tooling != 'Coverage' }}

- name: Code Coverage Run
run: |
conan install \
Expand All @@ -168,24 +193,11 @@ jobs:
--build missing \
.
conan build .
if: ${{ inputs.testing == 'True' && inputs.platform == 'ubuntu-22.04' && inputs.build-type == 'Debug' && inputs.malloc-impl == 'libc' && inputs.prerelease == 'False' }}
if: ${{ inputs.testing == 'True' && inputs.tooling == 'Coverage' }}

- name: Upload coverage reports to Codecov
uses: codecov/codecov-action@v3
with:
token: ${{ secrets.CODECOV_TOKEN }}
gcov: true
if: ${{ inputs.testing == 'True' && inputs.platform == 'ubuntu-22.04' && inputs.build-type == 'Debug' && inputs.malloc-impl == 'libc' && inputs.prerelease == 'False' }}


- name: Create and test Package
run: |
conan create \
-o sisl:prerelease=${{ inputs.prerelease }} \
-o sisl:malloc_impl=${{ inputs.malloc-impl }} \
-o sisl:testing=False \
-o iomgr:testing='epoll_mode' \
-s build_type=${{ inputs.build-type }} \
--build missing \
.
if: ${{ inputs.testing == 'True' }}
if: ${{ inputs.testing == 'True' && inputs.tooling == 'Coverage' }}
Original file line number Diff line number Diff line change
@@ -1,11 +1,15 @@
name: IOManager Merge Build
name: IOManager Build

on:
workflow_dispatch:
push:
branches:
- master
- stable/v8.x
pull_request:
branches:
- master
- stable/v8.x

jobs:
Build:
Expand All @@ -14,26 +18,29 @@ jobs:
matrix:
platform: ["ubuntu-22.04"]
build-type: ["Debug", "Release"]
malloc-impl: ["libc", "tcmalloc", "jemalloc"]
malloc-impl: ["libc", "tcmalloc"]
prerelease: ["True", "False"]
tooling: ["Sanitize", "Coverage", "None"]
exclude:
- malloc-impl: jemalloc
build-type: Debug
- malloc-impl: tcmalloc
build-type: Debug
- malloc-impl: tcmalloc
prerelease: "True"
- malloc-impl: jemalloc
- build-type: Debug
prerelease: "False"
- malloc-impl: libc
build-type: Release

- build-type: Debug
tooling: None
- build-type: Debug
malloc-impl: tcmalloc
- build-type: Release
malloc-impl: libc
- build-type: Release
tooling: Sanitize
- build-type: Release
tooling: Coverage
uses: ./.github/workflows/build_commit.yml
with:
platform: ${{ matrix.platform }}
build-type: ${{ matrix.build-type }}
malloc-impl: ${{ matrix.malloc-impl }}
prerelease: ${{ matrix.prerelease }}
tooling: ${{ matrix.tooling }}
ChainBuild:
runs-on: "ubuntu-22.04"
steps:
Expand All @@ -44,6 +51,6 @@ jobs:
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{ secrets.CHAIN_BUILD_TOKEN }}"\
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/eBay/homestore/actions/workflows/merge_conan_build.yml/dispatches \
https://api.github.com/repos/eBay/homestore/actions/workflows/conan_build.yml/dispatches \
-d '{"ref":"master","inputs":{}}'
if: ${{ github.ref == 'refs/heads/master' }}
33 changes: 0 additions & 33 deletions .github/workflows/pr_conan_build.yml

This file was deleted.

Loading
Loading