Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDSTOR-11552 fix docker build issue #42

Merged
merged 1 commit into from
Aug 16, 2023
Merged

SDSTOR-11552 fix docker build issue #42

merged 1 commit into from
Aug 16, 2023

Conversation

yamingk
Copy link
Contributor

@yamingk yamingk commented Aug 15, 2023 •
edited
Loading

Remove marco check, replace with runtime api check for availability.

Testing:

Tested with homestore multiple rounds and test binaries are passing.

@yamingk yamingk changed the title SDSTOR-xxxx fix docker build issue SDSTOR-11552 fix docker build issue Aug 15, 2023
szmyd
szmyd approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@szmyd szmyd merged commit 169654a into eBay:master Aug 16, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szmyd szmyd szmyd approved these changes

@hkadayam hkadayam Awaiting requested review from hkadayam

@shosseinimotlagh shosseinimotlagh Awaiting requested review from shosseinimotlagh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamingk @szmyd