Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty replace member function. #215

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion conanfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

class HomeObjectConan(ConanFile):
name = "homeobject"
version = "2.1.2"
version = "2.1.3"

homepage = "https://github.com/eBay/HomeObject"
description = "Blob Store built on HomeReplication"
Expand Down
2 changes: 1 addition & 1 deletion src/include/homeobject/pg_manager.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
namespace homeobject {

ENUM(PGError, uint16_t, UNKNOWN = 1, INVALID_ARG, TIMEOUT, UNKNOWN_PG, NOT_LEADER, UNKNOWN_PEER, UNSUPPORTED_OP,
CRC_MISMATCH, NO_SPACE_LEFT, DRIVE_WRITE_ERROR);
CRC_MISMATCH, NO_SPACE_LEFT, DRIVE_WRITE_ERROR, RETRY_REQUEST);

struct PGMember {
explicit PGMember(peer_id_t _id) : id(_id) {}
Expand Down
2 changes: 2 additions & 0 deletions src/lib/homestore_backend/hs_pg_manager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ PGError toPgError(ReplServiceError const& e) {
return PGError::NO_SPACE_LEFT;
case ReplServiceError::DRIVE_WRITE_ERROR:
return PGError::DRIVE_WRITE_ERROR;
case ReplServiceError::RETRY_REQUEST:
return PGError::RETRY_REQUEST;
/* TODO: enable this after add erro type to homestore
case ReplServiceError::CRC_MISMATCH:
return PGError::CRC_MISMATCH;
Expand Down
5 changes: 5 additions & 0 deletions src/lib/homestore_backend/replication_state_machine.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,11 @@ class ReplicationStateMachine : public homestore::ReplDevListener {
homestore::ReplResult< homestore::blk_alloc_hints > get_blk_alloc_hints(sisl::blob const& header,
uint32_t data_size) override;

/// @brief Called when replication module is replacing an existing member with a new member
void replace_member(homestore::replica_id_t member_out, homestore::replica_id_t member_in) override {
sanebay marked this conversation as resolved.
Show resolved Hide resolved
// TODO
}

/// @brief Called when the replica is being destroyed by nuraft;
void on_destroy() override;

Expand Down
Loading