Add german translations #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Can you just check what happen if for some reason one translation is missing? I don't remember the default behavior ... |
|
The default behavior is to fall back to the fallback resource (no language identifier), in this case English |
davideicardi
approved these changes
Sep 10, 2024
|
Any plans for a new version with the localization included? |
|
Just released 2.17.1 ! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds German translations
It seems like it's not possible to create translations for an external assembly using ResourceManager, and we need the errors in German.
I noticed this localization was added in #36, if @davideicardi or @jasonhumberstone know how I could provide translations from my project I would also be open to that.
If you ever need updates for the translations feel free to ping me.
I based the translations based on my understanding (mother tongue) and Microsoft's documentation translation.