Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Change some trimming functions to subshells #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

augustobmoura
Copy link

We can have the situation that shell options are already unset, in that case we actually change them to setted. The correct way of preventing shell options overriding is using a subshell, because all the functions that use set are only printing the result the subshell works like a charm.

Also we can remove the resetting of options and env vars at the end of the functions

to prevent options overriding
@augustobmoura
Copy link
Author

Kinda solves #7 too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant