Skip to content

Commit

Permalink
Remove Ruby 2 and Rails 5 defaults
Browse files Browse the repository at this point in the history
We are dropping integration test support for these end of life versions.

This work will focus solely on the integration tests and not the gem
itself.
  • Loading branch information
mec committed Aug 23, 2024
1 parent 0107aa9 commit abbb830
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# We want to support older Rubies
ARG RUBY_VERSION=2.7.8
ARG RUBY_VERSION=3.1.6
FROM registry.docker.com/library/ruby:$RUBY_VERSION-slim AS base

# Rails app lives here
Expand All @@ -12,9 +11,6 @@ FROM base AS build
RUN apt-get update -qq && \
apt-get install --no-install-recommends -y build-essential curl git

# Install Nokigiri version that supports Ruby 2.7.8
RUN gem install nokogiri -v 1.15.6

# Install Rails
ARG RAILS_VERSION=7.2.1
RUN gem install rails -v ${RAILS_VERSION}
Expand All @@ -27,9 +23,6 @@ WORKDIR mail-notify-integration
# install the gems into the bundle
RUN bundle install

# remove gems that will not work in Rails 5.2.8.1
RUN if [ "${RAILS_VERSION}" = "5.2.8.1" ]; then bundle remove selenium-webdriver chromedriver-helper; fi

# Final stage for app image
FROM base

Expand Down

0 comments on commit abbb830

Please sign in to comment.