Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(63) Show guidance on 3 day matrix of forecasts #33

Merged
merged 8 commits into from
Oct 8, 2024
Merged

(63) Show guidance on 3 day matrix of forecasts #33

merged 8 commits into from
Oct 8, 2024

Commits on Oct 7, 2024

  1. Extract DAQI value generator to a helper 

    We're going to use this to generate values for pollen in the
next commit.
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    61bd0e0 View commit details
    Browse the repository at this point in the history

  2. Model PollenPrediction and show guidance in forecast grid 

    We give the model responsbility for presenting:

- `daqi_level`: e.g. :low
- `daqi_label`: e.g. "Low"
- `guidance `: from our translation system (YAML
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    2a0e796 View commit details
    Browse the repository at this point in the history

  3. Refactor UvPrediction to use same interface as PollenPrediction 

    We're going to extract these common prediction methods to a
module in a later commit
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    6fd81e6 View commit details
    Browse the repository at this point in the history

  4. Refactor AirPollutionPrediction to use common interface 

    We'll extract out:

- `daqi_level`
- `daqi_label`

to a module and we'll have a clearer more consistent
interface.
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9339823 View commit details
    Browse the repository at this point in the history

  5. Extract DAQI properties to a module 

    And switch refactor PollenPrediction to use it.
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1da9ee8 View commit details
    Browse the repository at this point in the history

  6. Refactor UvPrediction to use DaqiProperties

    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    e4c7af9 View commit details
    Browse the repository at this point in the history

  7. Refactor AirPollutionPrediction to use DaqiProperties

    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5b146a5 View commit details
    Browse the repository at this point in the history

  8. Refactor: Forecast#forecast_for -> Forecast#date 

    This is much clearer, `#forecast_for` was a poor initial
choice!
    @edavey
    edavey committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    8f057f6 View commit details
    Browse the repository at this point in the history