(63) Show guidance on 3 day matrix of forecasts #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to use this to generate values for pollen in the next commit.
We give the model responsbility for presenting: - `daqi_level`: e.g. :low - `daqi_label`: e.g. "Low" - `guidance `: from our translation system (YAML
We're going to extract these common prediction methods to a module in a later commit
We'll extract out: - `daqi_level` - `daqi_label` to a module and we'll have a clearer more consistent interface.
And switch refactor PollenPrediction to use it.
This is much clearer, `#forecast_for` was a poor initial choice!
edavey
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Trello 63
In this PR we add guidance text for "pollen predictions" in the matrix of 3 day forecasts:
We don't add any more content for other rows at this point:
Air pollution
This is currently well developed in the Air Quality Alerts which are current shown above the table of 3 day predictions:
Temperature
We can easily add this in later.
We've done some refactoring to make our "predictions" more consistent:
DaqiPropertiesmodule to share#daqi_level(e.g.:moderate) and#daqi_labele.g."Moderate", and always use@valuefor the numeric score 1 to 10en.yml"translation" file