Present AirPollutionPrediction#overall_label in sentence case

dxw · Oct 3, 2024 · 4d661ec · 4d661ec
1 parent fd29de9
commit 4d661ec
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/app/models/air_pollution_prediction.rb b/app/models/air_pollution_prediction.rb
@@ -4,8 +4,7 @@ class AirPollutionPrediction
     :particulate_matter_10,
     :particulate_matter_2_5,
     :ozone,
-    :overall_score,
-    :overall_label
+    :overall_score
 
   def initialize(
     forecasted_at:,
@@ -25,6 +24,10 @@ def initialize(
     @overall_label = overall_label
   end
 
+  def overall_label
+    ActiveSupport::Inflector.upcase_first(@overall_label.downcase)
+  end
+
   def inspect
     attr_values = [
       "@forecasted_at=#{forecasted_at}",
@@ -33,7 +36,7 @@ def inspect
       "@particulate_matter_2_5=#{particulate_matter_2_5}",
       "@ozone=#{ozone}",
       "@overall_score=#{overall_score}",
-      "@overall_label=#{overall_label}"
+      "@overall_label=#{@overall_label}"
     ]
 
     "#<#{self.class.name} #{attr_values.join(" ")}>"

diff --git a/spec/lib/forecast_factory_spec.rb b/spec/lib/forecast_factory_spec.rb
@@ -18,7 +18,7 @@
              "temp_max" => 16.6,
              "temp_min" => 10.0,
              "total" => 2,
-             "total_status" => "LOW",
+             "total_status" => "VERY HIGH",
              "uv" => 2,
              "wind_am" => 4.9,
              "wind_pm" => 5.3}
@@ -52,7 +52,7 @@
         expect(forecast.air_pollution.particulate_matter_2_5).to eq(1)
         expect(forecast.air_pollution.ozone).to eq(2)
         expect(forecast.air_pollution.overall_score).to eq(2)
-        expect(forecast.air_pollution.overall_label).to eq("LOW")
+        expect(forecast.air_pollution.overall_label).to eq("Very high")
 
         expect(forecast.uv).to eq(2)
         expect(forecast.pollen).to eq(-999)