Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade module for kong v3 compatibility #108

Merged
merged 1 commit into from
May 23, 2024
Merged

feat: upgrade module for kong v3 compatibility #108

merged 1 commit into from
May 23, 2024

Conversation

odunlop
Copy link
Contributor

@odunlop odunlop commented May 14, 2024

Changes:

  • Adding logic to conditionally add new KONG_PORTAL_AND_VITALS_KEY if required (portal and vitals deprecated in V3 onwards)
  • Adding logic to conditionally change KONG_ADMIN_API_URI to KONG_ADMIN_GUI_API_URL depending on kong version [V3 breaking change]

Copy link

github-actions bot commented May 14, 2024

kics-logo

KICS version: v1.5.15

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 12
TRACE TRACE 0
TOTAL TOTAL 13
Metric Values
Files scanned placeholder 21
Files parsed placeholder 21
Files failed to scan placeholder 0
Total executed queries placeholder 1036
Queries failed to execute placeholder 0
Execution time placeholder 21

variables.tf Outdated Show resolved Hide resolved
@odunlop odunlop force-pushed the feat/kong3 branch 2 times, most recently from db4f7d1 to 51a4b73 Compare May 14, 2024 08:59
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odunlop odunlop merged commit fba89f2 into main May 23, 2024
3 checks passed
@odunlop odunlop deleted the feat/kong3 branch May 23, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants