Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rusk-wallet: Gracefully exit on interrupt #2646

Merged
merged 1 commit into from
Oct 24, 2024
Merged

rusk-wallet: Gracefully exit on interrupt #2646

merged 1 commit into from
Oct 24, 2024
+76 −22

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Oct 10, 2024 •
edited
Loading

  • Gracefully exit on interrupt
  • Ask confirmation before deleting cache

Screenshots

Screenshot 2024-10-10 at 2 32 23 PM
Screenshot 2024-10-10 at 2 24 47 PM

Closes #2577

@Daksh14 Daksh14 force-pushed the fix-2577 branch 3 times, most recently from 2419ee1 to 1dc3c6a Compare October 10, 2024 18:35
moCello
moCello reviewed Oct 11, 2024
View reviewed changes
rusk-wallet/src/bin/io/prompt.rs Outdated Show resolved Hide resolved
rusk-wallet/src/bin/main.rs Outdated Show resolved Hide resolved
rusk-wallet/src/wallet.rs Outdated Show resolved Hide resolved
@Daksh14 Daksh14 requested a review from moCello October 11, 2024 17:45
HDauven
HDauven previously approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@HDauven HDauven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think this is already a massive step up from the current behavior.

moCello
moCello reviewed Oct 18, 2024
View reviewed changes
rusk-wallet/Cargo.toml Outdated Show resolved Hide resolved
@Daksh14 Daksh14 closed this Oct 23, 2024
@Daksh14 Daksh14 reopened this Oct 23, 2024
@Daksh14 Daksh14 force-pushed the fix-2577 branch 4 times, most recently from 2b7460b to 5cefa45 Compare October 24, 2024 11:09
moCello
moCello reviewed Oct 24, 2024
View reviewed changes
rusk-wallet/src/wallet.rs Outdated Show resolved Hide resolved
rusk-wallet/src/bin/main.rs Outdated Show resolved Hide resolved
rusk-wallet/src/bin/main.rs Outdated Show resolved Hide resolved
@moCello moCello self-requested a review October 24, 2024 11:43
@Daksh14
rusk-wallet: Gracefully exit on interrupt
6e3485e 
Ask confimration before deleting cache
Make info message more accurate
@Daksh14 Daksh14 merged commit 445d869 into master Oct 24, 2024
11 checks passed
@Daksh14 Daksh14 deleted the fix-2577 branch October 24, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

@HDauven HDauven Awaiting requested review from HDauven

@moCello moCello Awaiting requested review from moCello

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rusk-wallet: wallet exits with "Please reset the cache!" message
3 participants
@Daksh14 @HDauven @moCello