-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port rusk-wallet to new wallet-core #2219
Conversation
Awesome work so far. I've been testing it a bit, and the transfer seems to work as expected. I've noticed the following bugs:
I've sent you the details in DM @Daksh14. If you want me to file bug reports, please let me know! |
This is currently an issue with our stake contract implementation. Can you open an issue? /cc @ureeves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Apart from the rfc's, I have some general requests:
- in "rusk-wallet/src/bin/command.rs" and "rusk-wallet/src/wallet/gas.rs" (and maybe other places too) why did you change
Lux
tou64
? I think it's important to make it clear where au64
is referring to units ofDusk
and where it is referring to units ofLux
. Both can be represented inu64
but 1Lux
is not the same as 1Dusk
- we now have
Dusk
implemented twice, once inexecution-core
and here in thecurrency
module. I would like it to be in one place only and I think it makes the most sense to introduce thecurrency
module inexecution-core
. - please remove all references to the spent-keys, in both the code and comments. The key naming changed and the spent-keys are now phoenix-keys. That means that the short psk, formerly referring to public-spend-key, now will likely be interpreted as phoenix-secret-key, causing confusion.
- please refer to the crate-module as
crate
instead ofdusk_wallet
- Atm the workspace member has a different name than the crate itself but it might be nice to have them match and settle for both to either be
dusk-wallet
orrusk-wallet
- I don't find the mechanism of how we delegate the proof-generation
- the seed and all secret-keys need to be zeroized after being used
69029c0
to
5778e64
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still some open RFC's
0abb72d
to
0f383bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some open review comments but I'll approve for now so that we can deal with them in follow up issues.
Please have another look at the commits though. After the first line there always needs to be an empty line.
00df9aa
to
5599459
Compare
- Change crate name to - Acclimate to the new naming scheme of keys and types - Zerorize secret keys - Acclimate to new phoenix_balance method
- Add algorithm for picking notes - Re-export some commonly used types
5599459
to
645ea51
Compare
closes #2143