Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Periodically remove expired transactions from mempool #2114

Merged
merged 7 commits into from
Aug 21, 2024
Merged

node: Periodically remove expired transactions from mempool #2114

merged 7 commits into from
Aug 21, 2024

Conversation

goshawk-3
Copy link
Contributor

@goshawk-3 goshawk-3 commented Aug 13, 2024 •
edited
Loading

fixes #2096
fixes #1948

@goshawk-3 goshawk-3 marked this pull request as ready for review August 14, 2024 09:03
fed-franz
fed-franz reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@fed-franz fed-franz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM but:

Is there a specific reason for having timestamps passed as parameters instead of computing them inside add_tx and get_expired_txs?

node/src/mempool.rs Show resolved Hide resolved
node/src/mempool.rs Outdated Show resolved Hide resolved
@goshawk-3 goshawk-3 merged commit 3e7209a into master Aug 21, 2024
8 checks passed
@goshawk-3 goshawk-3 deleted the fix-2096 branch August 21, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fed-franz fed-franz fed-franz approved these changes

@herr-seppia herr-seppia Awaiting requested review from herr-seppia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node: Periodically clear expired/accepted transactions from the mempool Re-introduce Mempool synchronization
2 participants
@goshawk-3 @fed-franz