Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web-wallet: Integration with latest wallet-js and Sync improvements #2109

Merged
merged 1 commit into from
Sep 6, 2024
Merged

web-wallet: Integration with latest wallet-js and Sync improvements #2109

merged 1 commit into from
Sep 6, 2024

Conversation

nortonandreev
Copy link
Contributor

@nortonandreev nortonandreev commented Aug 12, 2024 •
edited
Loading

Resolves #1561, Resolves #1567, Resolves #1568, Resolves #1570, Resolves #1595

This PR includes the following features / enhancements:

  • Integration with the latest wallet-js library
  • Display of the current network block height during wallet creation
  • Prevention of full sync for newly created wallets
  • Option for users to restore a wallet from either genesis or a specific block height
  • Relocation of the initial sync to the wallet restore flow
  • A sync indicator that displays progress for both initial and subsequent syncs

@nortonandreev nortonandreev self-assigned this Aug 12, 2024
@nortonandreev nortonandreev force-pushed the feature-1570 branch 3 times, most recently from dcb06d1 to f2e899a Compare August 22, 2024 12:20
@nortonandreev nortonandreev changed the title web-wallet: Update the Sync indicator to reflect the actual progress [WIP] web-wallet: Integration with latest wallet-js and Sync improvements [WIP] Aug 22, 2024
@nortonandreev nortonandreev mentioned this pull request Aug 22, 2024
Closed
@nortonandreev nortonandreev marked this pull request as ready for review August 25, 2024 15:16
@nortonandreev
Copy link
Contributor Author

nortonandreev commented Aug 25, 2024 •
edited
Loading

The should initialize the wallet without setting a password (in Wallet Create) fails for some reason – seems that the userId is still set in the settings store. If I call settingsStore.reset() explicitly before the Create component is rendered, it works as expected. However, it worries me that something is wrong with the store resetting/setting.

Could you please assist debugging, @ascartabelli? 🙏 Thanks!

Update: Solved

@ascartabelli
Copy link
Contributor

The should initialize the wallet without setting a password (in Wallet Create) fails for some reason – seems that the userId is still set in the settings store. If I call settingsStore.reset() explicitly before the Create component is rendered, it works as expected. However, it worries me that something is wrong with the store resetting/setting.

Could you please assist debugging, @ascartabelli? 🙏 Thanks!

Remember to push the branch when you're done and I'll have a look first thing in the morning.

ascartabelli
ascartabelli reviewed Aug 26, 2024
View reviewed changes
Copy link
Contributor

@ascartabelli ascartabelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just a quick pre-review, left some comments around.

In any case: really a great job!

web-wallet/.eslintignore Show resolved Hide resolved
web-wallet/src/lib/dusk/components/CopyField/CopyField.svelte Outdated Show resolved Hide resolved
web-wallet/src/lib/dusk/components/CopyField/CopyField.svelte Outdated Show resolved Hide resolved
web-wallet/src/lib/dusk/components/CopyField/CopyField.svelte Outdated Show resolved Hide resolved
web-wallet/src/lib/dusk/number/createNumberFormatter.js Outdated Show resolved Hide resolved
web-wallet/src/lib/stores/walletStore.js Outdated Show resolved Hide resolved
web-wallet/src/lib/stores/walletStore.js Outdated Show resolved Hide resolved
web-wallet/src/lib/stores/walletStore.js Outdated Show resolved Hide resolved
web-wallet/src/routes/(welcome)/setup/restore/NetworkSyncProgress.svelte Show resolved Hide resolved
@ZER0 ZER0 changed the title web-wallet: Integration with latest wallet-js and Sync improvements [WIP] web-wallet: Integration with latest wallet-js and Sync improvements Aug 29, 2024
@nortonandreev nortonandreev force-pushed the feature-1570 branch 4 times, most recently from 22a2287 to b4fe174 Compare September 4, 2024 07:42
@nortonandreev nortonandreev force-pushed the feature-1570 branch 5 times, most recently from 58ada57 to 1187d36 Compare September 6, 2024 08:25
@ascartabelli @nortonandreev
web-wallet: Integration with latest wallet-js and Sync improvements
d4a9cf6 
Resolves #1561, Resolves #1567, Resolves #1568, Resolves #1570, Resolves #1595

Changelog:
- Integration with the latest wallet-js library (v.0.5.3)
- Display of the current network block height during wallet creation
- Prevention of full sync for newly created wallets
- Option for users to restore a wallet from either genesis or a specific block height
- Relocation of the initial sync to the wallet restore flow
- A sync indicator that displays progress for both initial and subsequent syncs
@nortonandreev nortonandreev merged commit 60158c1 into master Sep 6, 2024
15 checks passed
@nortonandreev nortonandreev deleted the feature-1570 branch September 6, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ascartabelli ascartabelli ascartabelli approved these changes

@kieranhall kieranhall Awaiting requested review from kieranhall

@deuch13 deuch13 Awaiting requested review from deuch13

Assignees

@ascartabelli ascartabelli

@nortonandreev nortonandreev

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@nortonandreev @ascartabelli