Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .NET Framework 4.7.1 to the target frameworks #38

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

yevgenkre
Copy link
Contributor

Adding .NET Framework 4.7.1 to the target frameworks, bumping the version to 1.2.3

Description

Modified the project file to accommodate the .NET Framework 4.7.1 support

Motivation and Context

Current DuoEpicHyperdrive integration runs on old environments, the min support version 4.6.1 of .NET Framework, but Epic overall is fine to target 4.7.1 on our end. The existing dll, targeting netstandard 2.0 has compatibility issues, which can be resolved either with a binding redirect (which requires modification of the files in the customer's app folder) or the current solution, which is implementing the binding in the code, but needs a dll, specifically targeting version 4.7.1, otherwise there are compatibility issues with the System.Text.Json lib and System.Runtime.CompilerServices.Unsafe.

How Has This Been Tested?

Using the local builds and running with the Epic's test harness app doesn't throw incompatibility exceptions when testing.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AaronAtDuo
Copy link
Contributor

LGTM. will merge Monday

@AaronAtDuo AaronAtDuo merged commit 7dd4c62 into duosecurity:main Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants