Add support for v5 signatures #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jaherne-duo I don't 100% follow the CI errors but based on the versions that failed, I'm gonna guess you tried to use a feature that was added in Node 14 so the lower versions fail? |
AaronAtDuo
reviewed
Jan 9, 2024
AaronAtDuo
reviewed
Jan 9, 2024
AaronAtDuo
reviewed
Jan 9, 2024
AaronAtDuo
reviewed
Jan 9, 2024
AaronAtDuo
reviewed
Jan 9, 2024
spencermaxfield
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new field to
jsonApiCallto support v5 signatures. Also adds a new example file showing how to call Policy API endpoints.Motivation and Context
We've received requests to add support for Policy Admin API endpoints with the Node.js client.
How Has This Been Tested?
Added new test file, verified that existing calls did not break.
Types of Changes