Export RetrieveItems function for external use and standardize naming #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in admin module - Exported the RetrieveItems function to allow its use outside the admin package. - Corrected a typo in a comment within the User struct definition. - Standardized naming conventions by updating variable names to camelCase (e.g., asserted_users -> assertedUsers). - Renamed the `responsePage` interface to `ResponsePage` for use outside package. - Refactored methods and callback functions to use the newly exported `RetrieveItems` function and `ResponsePage` interface.
|
@duosecurity I don't see a CONTRIBUTING.md file in here - is there anything else needed to get this rolled out? |
|
@jaherne-duo / @AaronAtDuo - any ideas on who maintains this repository and if this can be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export RetrieveItems function for external use and standardize naming
Description
responsePageinterface toResponsePagefor use outside package.RetrieveItemsfunction andResponsePageinterface.Motivation and Context
I made this change since
/admin/v1/integrationsis not exposed in this SDK. Rather than auditing all missing endpoints, I figured this helper function can be exposed so consumers can make use of this in the event multiple are missing.How Has This Been Tested?
Types of Changes