-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong addition solved in add_faux_rows by adding parseInt #426
base: master
Are you sure you want to change the base?
Conversation
Is it worth doing this to line 3826 as well (columns)? |
@jhowley1989 good point, probably yes. I didn't experience any problems with it, but I assume this will cause the same problems. |
@jhowley1989 I also added it to the columns. Hope this will be pulled soon. |
It was confirmed that this also solves #340 Any idea when this will be pulled? |
I encountered the same issue with the slowdown. This patch fixes it. |
@mrud great to hear. To bad it isn't being pulled, that would avoid hours of searching for something that is already fixed. |
Looks great I merged it into my fork dsmorse/gridster.js |
This solves #425.
The
fn.add_faux_rows = function(rows) {
var actual_rows = this.rows;
var max_rows = actual_rows + (rows || 1);
The second part was being added as a string before this patch. This gave a huge row number and caused lots of lags. Now it flies again.
I think also related to:
#340 (see comments of canfiax)