Remove Engadget workaround from google-ima shim #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a workaround in the google-ima shim that applied only to
www.engadget.com that set a current advert to be returned by
AdEvent.getAd() and AdsManager.getCurrentAd(). When testing the
website, I couldn't see that code-path being hit at all, so let's
remove the workaround. Also, let's take care to return null instead of
undefined as is specified[1].
In the future, we could expand this logic if necessary. I think
setting the currentAd to new Ad() when the AdEvent.Type.LOADED event
fires and back to null when AdEvent.Type.ALL_ADS_COMPLETED fires would
make sense - but we would need to test that doesn't cause more website
breakage first.
1 - https://developers.google.com/interactive-media-ads/docs/sdks/html5/client-side/reference/js/google.ima.AdEvent#getAd