Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more noop.js redirection rules #31

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

kzar
Copy link
Contributor

@kzar kzar commented Nov 28, 2023

After analysing uBlock[1] and Mozilla's[2] shim redirection rules, we
found some more noop.js redirections that fixed reproducible site
breakage. Let's add those rules now.

1 - https://github.com/gorhill/uBlock/blob/master/assets/assets.json
2 - https://hg.mozilla.org/mozilla-central/raw-file/tip/browser/extensions/webcompat/data/shims.js

@kzar kzar requested a review from dharb November 28, 2023 12:56
@kzar kzar changed the title Expand1 noop rules Add some more noop.js redirection rules Nov 28, 2023
@dharb dharb marked this pull request as ready for review November 30, 2023 00:10
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

After analysing uBlock[1] and Mozilla's[2] shim redirection rules, we
found some more noop.js redirections that fixed reproducible site
breakage. Let's add those rules now.

1 - https://github.com/gorhill/uBlock/blob/master/assets/assets.json
2 - https://hg.mozilla.org/mozilla-central/raw-file/tip/browser/extensions/webcompat/data/shims.js
@kzar kzar merged commit 3fc4b46 into duckduckgo:main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants