Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameters to broken sites #57

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

marcosholgado
Copy link
Contributor

https://app.asana.com/0/0/1203012116406182/f

This PR adds the missing parameters for autoconsent and urlParameterRemoved to the broken sites test

broken-site-reporting/tests.json Outdated Show resolved Hide resolved
broken-site-reporting/tests.json Outdated Show resolved Hide resolved
broken-site-reporting/tests.json Outdated Show resolved Hide resolved
@GuiltyDolphin
Copy link
Member

@marcosholgado I think we want to update the README too, with:

  • urlParametersRemoved - boolean - if URL parameters were removed
  • consentManaged - boolean - if a cookie popup was handled on the page
  • consentOptoutFailed - boolean - if the opt-out process failed
  • consentSelftestFailed - boolean - if the rule's self-test failed

@marcosholgado
Copy link
Contributor Author

@marcosholgado I think we want to update the README too, with:

  • urlParametersRemoved - boolean - if URL parameters were removed
  • consentManaged - boolean - if a cookie popup was handled on the page
  • consentOptoutFailed - boolean - if the opt-out process failed
  • consentSelftestFailed - boolean - if the rule's self-test failed

Yup! Done

@GuiltyDolphin
Copy link
Member

Okay this LGMT unless we:

  1. want to include the params in the expectReportURLParams field (cc @kdzwinel)
  2. want to add any tests where these params are going to be set to 1

Copy link
Member

@kdzwinel kdzwinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, now that we have those new params we should add some tests that actually use them. This can be a follow up PR though.

@@ -20,6 +20,10 @@
{"name": "blockedTrackers", "value": "bad.tracker.test,tracking.test"},
{"name": "surrogates", "value": "surrogate.domain.test"}
],
"urlParametersRemoved": "0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme says that those were meant to be booleans?

Copy link
Contributor Author

@marcosholgado marcosholgado Sep 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point :D Actually it depends on how you define a boolean, is it true/false or 1/0 or is it the same thing? The reporting failed because we were using true/false and the expectation was 1/0 so I guess is not really a boolean but a value of 1 or 0.

I think 1/0 is confusing though and we are using booleans in other places (i.e. true/false for wasUpgraded) so I find it weird that these few parameters need 1/0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants