Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Android unit tests to reference-test matrix #117

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sammacbeth
Copy link
Collaborator

@sammacbeth sammacbeth commented Nov 10, 2023

Runs android unit-tests against reference-test PRs.

@sammacbeth sammacbeth force-pushed the sam/android-tests branch 4 times, most recently from e1782b7 to ea9abef Compare November 10, 2023 12:49
@sammacbeth sammacbeth marked this pull request as ready for review November 10, 2023 13:15
@marcosholgado
Copy link
Contributor

This workflow is only running JVM tests rather than all the tests so it will miss reference tests that are not JVM (all Android tests). As I said on MM, I would try to find a way to execute our workflow within this workflow, i.e. https://dev.to/moaaz_adel/github-actions-a-simple-way-to-trigger-workflow-from-another-workflow-1b55

Another advantage of that is that we tweak our workflows every now and then and we will have to remember to come here to tweak this one too if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants