Email Manager keychain error reporting (#662)

Task/Issue URL: https://app.asana.com/0/414235014887631/1202679436624547/f Tech Design URL: CC: Description: This PR is the macOS equivalent of duckduckgo/BrowserServicesKit#123. Steps to test this PR: See the BSK PR for testing steps The one difference is that you will have to turn Pixel logging on in Logging.swift
duckduckgo · Jul 29, 2022 · a182c96 · a182c96
1 parent 3811d69
commit a182c96
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 1 deletion.
diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -5988,7 +5988,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 18.0.5;
+				version = 19.0.0;
 			};
 		};
 		AA06B6B52672AF8100F541C5 /* XCRemoteSwiftPackageReference "Sparkle" */ = {

diff --git a/DuckDuckGo/Autofill/ContentOverlayViewController.swift b/DuckDuckGo/Autofill/ContentOverlayViewController.swift
@@ -165,6 +165,19 @@ public final class ContentOverlayViewController: NSViewController, EmailManagerR
         }.resume()
     }
     // swiftlint:enable function_parameter_count
+
+    public func emailManagerKeychainAccessFailed(accessType: EmailKeychainAccessType, error: EmailKeychainAccessError) {
+        var parameters = [
+             "access_type": accessType.rawValue,
+             "error": error.errorDescription
+         ]
+
+         if case let .keychainAccessFailure(status) = error {
+             parameters["keychain_status"] = String(status)
+         }
+
+        Pixel.fire(.debug(event: .emailAutofillKeychainError), withAdditionalParameters: parameters)
+    }
 
     private enum Constants {
         static let minWidth: CGFloat = 315

diff --git a/DuckDuckGo/Email/EmailManagerRequestDelegate.swift b/DuckDuckGo/Email/EmailManagerRequestDelegate.swift
@@ -50,5 +50,18 @@ extension EmailManagerRequestDelegate {
         }.resume()
     }
     // swiftlint:enable function_parameter_count
+
+    public func emailManagerKeychainAccessFailed(accessType: EmailKeychainAccessType, error: EmailKeychainAccessError) {        
+        var parameters = [
+             "access_type": accessType.rawValue,
+             "error": error.errorDescription
+         ]
+
+         if case let .keychainAccessFailure(status) = error {
+             parameters["keychain_status"] = String(status)
+         }
+
+        Pixel.fire(.debug(event: .emailAutofillKeychainError), withAdditionalParameters: parameters)
+    }
 
 }
diff --git a/DuckDuckGo/Statistics/PixelEvent.swift b/DuckDuckGo/Statistics/PixelEvent.swift
@@ -213,6 +213,8 @@ extension Pixel {
             case feedbackReportingFailed = "feedback_reporting_failed"
 
             case blankNavigationOnBurnFailed = "blank_navigation_on_burn_failed"
+
+            case emailAutofillKeychainError = "email_autofill_keychain_error"
         }
 
     }