-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix closing tabs quickly * update evilHackToClearLastLeftHitInWindow * fix test * Fix mouse-exit events not handled correctly * minor adjustment
- Loading branch information
Showing
6 changed files
with
122 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
Unit Tests/Common/AppKitPrivateMethodsAvailabilityTests.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| // | ||
| // AppKitPrivateMethodsAvailabilityTests.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import XCTest | ||
| import AppKit | ||
| @testable import DuckDuckGo_Privacy_Browser | ||
|
|
||
| final class AppKitPrivateMethodsAvailabilityTests: XCTestCase { | ||
|
|
||
| func testLastLeftHitViewIsReleasedCorrectly() { | ||
| var window: NSWindow! | ||
| autoreleasepool { | ||
| window = NSWindow() | ||
| window.isReleasedWhenClosed = false | ||
|
|
||
| let view = TestHitView(frame: NSRect(x: 0, y: 0, width: 100, height: 100)) | ||
| window.contentView = view | ||
|
|
||
| window.setFrame(NSRect(x: 0, y: 0, width: 100, height: 123), display: false) | ||
| NSApp.activate(ignoringOtherApps: true) | ||
|
|
||
| let didAppearExpectation = expectation(description: "view did appear") | ||
| window.makeKeyAndOrderFront(nil) | ||
| DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) { | ||
| didAppearExpectation.fulfill() | ||
| } | ||
| waitForExpectations(timeout: 1.0) | ||
|
|
||
| view.mouseDownExpectation = expectation(description: "mouseDown received") | ||
|
|
||
| let event = NSEvent.mouseEvent(with: .leftMouseDown, | ||
| location: NSPoint(x: 50, y: 50), | ||
| modifierFlags: [], | ||
| timestamp: CACurrentMediaTime(), | ||
| windowNumber: window.windowNumber, | ||
| context: nil, | ||
| eventNumber: -22966, | ||
| clickCount: 1, | ||
| pressure: 1)! | ||
| window.postEvent(event, atStart: false) | ||
|
|
||
| waitForExpectations(timeout: 0.1) | ||
|
|
||
| // window should have lastLeftHit set to the clicked view after a click event | ||
| XCTAssertEqual(window.lastLeftHit, view) | ||
| window.evilHackToClearLastLeftHitInWindow() | ||
| XCTAssertEqual(window.lastLeftHit, nil) | ||
|
|
||
| view.deinitExpectation = expectation(description: "deinit called") | ||
| window.close() | ||
| window = nil | ||
| } | ||
|
|
||
| waitForExpectations(timeout: 0.5) | ||
| } | ||
|
|
||
| } | ||
|
|
||
| private class TestHitView: NSView { | ||
| var mouseDownExpectation: XCTestExpectation! | ||
| var deinitExpectation: XCTestExpectation! | ||
|
|
||
| override func mouseDown(with event: NSEvent) { | ||
| mouseDownExpectation.fulfill() | ||
| super.mouseDown(with: event) | ||
| } | ||
|
|
||
| deinit { | ||
| deinitExpectation.fulfill() | ||
| } | ||
|
|
||
| } |