-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update the home page to preserve the scheme of the original URL. (#705)
Task/Issue URL: https://app.asana.com/0/1199230911884351/1202894007986850/f Tech Design URL: CC: Description: This PR updates the new tab page to remember the scheme that was used to open URLs from history.
- Loading branch information
Showing
3 changed files
with
85 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| // | ||
| // RecentlyVisitedSiteModelTests.swift | ||
| // | ||
| // Copyright © 2022 DuckDuckGo. All rights reserved. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // | ||
|
|
||
| import XCTest | ||
| @testable import DuckDuckGo_Privacy_Browser | ||
|
|
||
| class RecentlyVisitedSiteModelTests: XCTestCase { | ||
|
|
||
| func testWhenOriginalURLIsHTTPS_ThenModelURLIsHTTPS() { | ||
| assertModelWithURL(URL(string: "https://example.com")!, matches: URL(string: "https://example.com")!, expectedDomain: "example.com") | ||
| } | ||
|
|
||
| func testWhenOriginalURLIsHTTP_ThenModelURLIsHTTP() { | ||
| assertModelWithURL(URL(string: "http://example.com")!, matches: URL(string: "http://example.com")!, expectedDomain: "example.com") | ||
| } | ||
|
|
||
| func testWhenOriginalURLContainsAdditionalInformation_ThenModelURLOnlyUsesSchemeAndHost() { | ||
| assertModelWithURL(URL(string: "http://example.com/path?test=true#fragment")!, matches: URL(string: "http://example.com")!, expectedDomain: "example.com") | ||
| assertModelWithURL(URL(string: "https://example.com/path?test=true#fragment")!, matches: URL(string: "https://example.com")!, expectedDomain: "example.com") | ||
| } | ||
|
|
||
| func testWhenOriginalURLContainsWWW_ThenDomainDoesNotIncludeIt() { | ||
| assertModelWithURL(URL(string: "http://www.example.com")!, matches: URL(string: "http://www.example.com")!, expectedDomain: "example.com") | ||
| } | ||
|
|
||
| private func assertModelWithURL(_ url: URL, matches expectedURL: URL, expectedDomain: String) { | ||
| let model = HomePage.Models.RecentlyVisitedSiteModel(originalURL: url) | ||
| XCTAssertEqual(model?.domain, expectedDomain) | ||
| XCTAssertEqual(model?.url, expectedURL) | ||
| } | ||
|
|
||
| } |