Move is_scheduled_release to ddg_apple_automation_helper

duckduckgo · Oct 2, 2024 · 82a3bc5 · 82a3bc5
1 parent 846484e
commit 82a3bc5
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 18 deletions.
diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_create_action_item_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_create_action_item_action.rb
@@ -98,6 +98,7 @@ def self.details
       def self.available_options
         [
           FastlaneCore::ConfigItem.asana_access_token,
+          FastlaneCore::ConfigItem.is_scheduled_release,
           FastlaneCore::ConfigItem.new(key: :task_url,
                                        description: "Asana release task URL",
                                        optional: false,
@@ -127,12 +128,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :github_handle,
                                        description: "Github user handle",
                                        optional: true,
-                                       type: String),
-          FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
-                                       description: "Indicates whether the release was scheduled or started manually",
-                                       optional: true,
-                                       type: Boolean,
-                                       default_value: false)
+                                       type: String)
         ]
       end
 

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -2,6 +2,7 @@
 require "fastlane_core/configuration/config_item"
 require "asana"
 require_relative "../helper/asana_helper"
+require_relative "../helper/ddg_apple_automation_helper"
 require_relative "asana_add_comment_action"
 require_relative "asana_get_user_id_for_github_handle_action"
 
@@ -78,6 +79,7 @@ def self.details
       def self.available_options
         [
           FastlaneCore::ConfigItem.asana_access_token,
+          FastlaneCore::ConfigItem.is_scheduled_release,
           FastlaneCore::ConfigItem.new(key: :task_url,
                                        description: "Asana release task URL",
                                        optional: false,
@@ -99,12 +101,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :github_handle,
                                        description: "Github user handle",
                                        optional: true,
-                                       type: String),
-          FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
-                                       description: "Indicates whether the release was scheduled or started manually",
-                                       optional: true,
-                                       type: Boolean,
-                                       default_value: false)
+                                       type: String)
         ]
       end
 

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/tag_release_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/tag_release_action.rb
@@ -209,6 +209,7 @@ def self.available_options
         [
           FastlaneCore::ConfigItem.asana_access_token,
           FastlaneCore::ConfigItem.github_token,
+          FastlaneCore::ConfigItem.is_scheduled_release,
           FastlaneCore::ConfigItem.platform,
           FastlaneCore::ConfigItem.new(key: :asana_task_url,
                                        description: "Asana release task URL",
@@ -237,12 +238,7 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :is_prerelease,
                                        description: "Is this a pre-release? (a.k.a. internal release)",
                                        optional: false,
-                                       type: Boolean),
-          FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
-                                       description: "Indicates whether the release was scheduled or started manually",
-                                       optional: true,
-                                       type: Boolean,
-                                       default_value: false)
+                                       type: Boolean)
         ]
       end
 

diff --git a/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb b/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb
@@ -372,5 +372,13 @@ def self.platform
                                      UI.user_error!("platform must be equal to 'ios' or 'macos'") unless ['ios', 'macos'].include?(value.to_s)
                                    end)
     end
+
+    def self.is_scheduled_release
+      FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
+                                   description: "Indicates whether the release was scheduled or started manually",
+                                   optional: true,
+                                   type: Boolean,
+                                   default_value: false)
+    end
   end
 end