shopping: add title for Shopping Vertical filter modal #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjbarag
changed the title
Translate duckduckgo to af_ZA
Translate duckduckgo to pt_PT
Translate duckduckgo to lt_LT
|
@sjbarag Is this good to merge? It includes a highly visible fix we updated in Smartling and got pushed to the only open branch. If this is not good to merge, please let me know and I will include that fix separately. |
|
Ah, I didn't realize this wasn't limited to my Smartling job. No concerns from me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're running an experiment with filters in the Shopping Vertical1 that places those filters in a modal. By design's request, we should use the same string for both the modal title and the button label. Add that label to the translation
.pofiles.Note: This PR seems to include a few unrelated changes, but I'm not sure why.
Footnotes
https://app.asana.com/0/72649045549333/1205601300148748/f ↩