Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate travis CI to github actions #693

Merged
merged 8 commits into from
May 3, 2024
Merged

Migrate travis CI to github actions #693

merged 8 commits into from
May 3, 2024

Conversation

snobear
Copy link
Contributor

@snobear snobear commented May 2, 2024 •
edited
Loading

  • Add Github action workflow to run prove tests on pull requests (added as a required check under branch protections)
  • Remove travis CI config (removed this as a required check under branch protections)

@snobear snobear requested a review from chris-ddg May 2, 2024 15:31
chris-ddg
chris-ddg approved these changes May 3, 2024
View reviewed changes
Copy link

@chris-ddg chris-ddg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs review from DRIs... I'll ping on the Asana task.

GioSensation
GioSensation approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These actions are hard to test. Overall this looks fine, let's see if it breaks 🙂.

@snobear snobear merged commit b8f2efc into master May 3, 2024
1 check passed
@snobear snobear deleted the gha branch May 3, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioSensation GioSensation GioSensation approved these changes

@chris-ddg chris-ddg chris-ddg approved these changes

@moollaza moollaza Awaiting requested review from moollaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snobear @GioSensation @chris-ddg