fix: if no details are available don't show the tooltip (#649)

duckduckgo · Sep 9, 2024 · 1fee787 · 1fee787
1 parent d879b6c
commit 1fee787
Show file tree

Hide file tree

Showing 5 changed files with 40 additions and 26 deletions.
diff --git a/dist/autofill-debug.js b/dist/autofill-debug.js
diff --git a/dist/autofill.js b/dist/autofill.js
diff --git a/src/Form/Form.js b/src/Form/Form.js
@@ -771,12 +771,14 @@ class Form {
             // we'd have any other items to show. This lets us know if we're
             // just showing in-context signup, or with other autofill items.
             const hasSavedDetails = this.device.settings.canAutofillType({ mainType, subtype, variant }, null)
-
-            if (this.isCredentialsImoprtAvailable) return true
-
-            // Don't open the tooltip on input focus whenever it'll only show in-context signup
-            if (!hasSavedDetails && isIncontextSignupAvailable) return false
-            return true
+            if (hasSavedDetails) {
+                return true
+            } else if (isIncontextSignupAvailable) {
+                // Don't open the tooltip on input focus whenever it'll only show in-context signup
+                return false
+            } else {
+                return this.isCredentialsImoprtAvailable
+            }
         }
 
         if (this.device.globalConfig.isExtension || this.device.globalConfig.isMobileApp) {

diff --git a/swift-package/Resources/assets/autofill-debug.js b/swift-package/Resources/assets/autofill-debug.js
diff --git a/swift-package/Resources/assets/autofill.js b/swift-package/Resources/assets/autofill.js