set screenY and screenTop to 0 when equal to screen height #889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladamski
force-pushed
the
la/test-mac-screenY-fix
branch
from
d5f7786
to
06d95ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background: https://app.asana.com/0/276630244458377/1206165160907347/f
See also https://developer.mozilla.org/en-US/docs/Web/API/Window/screenY
For Mac where we are incorrectly providing the screen height instead of
A number equal to the number of CSS pixels from the top edge of the browser viewport to the top edge of the screen., which should be the actual value or 0.