added webCompat as a docs page #690
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Some errors in the build though. |
| * | ||
| * A suite of individual 'fixes' | ||
| * | ||
| * - {@link default.windowSizingFix Window Sizing Fix} |
There was a problem hiding this comment.
Kinda shame we need to do this, is there no other way?
There was a problem hiding this comment.
yeah it's not the nicest, but it is checked at build time which makes it slightly better.
another way, would be to encapsulate each sub feature into it's own class/module - but I think that might be going further than you want (in terms of code change for docs).
There was a problem hiding this comment.
or, we can omit the list - it was just a nice way to list them when you land on the top-level webCompat
There was a problem hiding this comment.
I don't mind, just don't really like having manual steps and loads of boilerplate to make docs happy. I'll let you make the judgement here, I agree splitting to separate classes seems a little overkill too, but I don't mind if there's other benefits.
shakyShane
force-pushed
the
08-15-added_webCompat_as_a_docs_page
branch
2 times, most recently
from
a5dc2a4
to
5f7f31a
Compare
shakyShane
force-pushed
the
08-15-added_webCompat_as_a_docs_page
branch
from
5c50bb2
to
5140918
Compare
|
Converted to draft |
Added some basic support for documenting Web Compat features - something to build upon