-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Autofill password import] Misc fixes #1184
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for content-scope-scripts ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Temporary Branch UpdateThe temporary branch has been updated with the latest changes. Below are the details:
Please use the above install command to update to the latest version. |
[Beta] Generated file diffTime updated: Fri, 01 Nov 2024 14:13:46 GMT Android
File has changed Integration
File has changed |
1058d41
to
b079299
Compare
297ad13
to
11e20f0
Compare
11e20f0
to
b3ade5c
Compare
dd502ec
to
7a69964
Compare
65dac43
to
38f843d
Compare
…content-scope-scripts into dbajpeyi/fix/supported-paths
0afb993
to
100aa6b
Compare
@@ -41,7 +41,7 @@ export class UpdateNotificationService { | |||
*/ | |||
dismiss () { | |||
this.ntp.messaging.notify('updateNotification_dismiss') | |||
// eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some new eslint changes seem to have forced this when I did a lint-fix
…content-scope-scripts into dbajpeyi/fix/supported-paths
7964075
to
8ad828f
Compare
Asana Task/Github Issue: https://app.asana.com/0/1205996472158114/1208671198302487/f
Description
indexOf
byincludes
, however I replaced the functionality 😄Original PR: [Google password manager] Android isolated module for password import #1157. This was causing login to break, and also causing other animations to break.
scrollIntoView
fails if the layout is not fully rendered (edge case).Testing Steps
feature/craig/autofill_gpm_ui_to_launch_from_password_manager
) with the confighttps://jsonblob.com/api/1301563859532636160
Checklist
Please tick all that apply: