Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ntp: favorites drag and drop #1150

Draft
wants to merge 4 commits into
base: ntp_add_pragmatic-drag-and-drop
Choose a base branch
from
Draft

ntp: favorites drag and drop #1150

wants to merge 4 commits into from

Conversation

shakyShane
Copy link
Contributor

@shakyShane shakyShane commented Oct 21, 2024 •
edited
Loading

Asana Task/Github Issue: https://app.asana.com/0/0/1208684961069939/f

Description

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

@shakyShane
Copy link
Contributor Author

shakyShane commented Oct 21, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
10 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

[Beta] Generated file diff

Time updated: Mon, 04 Nov 2024 16:56:27 GMT

Integration 
    - integration/pages/new-tab/js/index.css
  • integration/pages/new-tab/js/index.js
  • integration/pages/new-tab/js/mock-transport.js

File has changed

Windows 
    - windows/pages/new-tab/js/index.css
  • windows/pages/new-tab/js/index.js
  • windows/pages/new-tab/js/mock-transport.js

File has changed

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

@shakyShane shakyShane changed the base branch from stats_keyboard_support to 10-21-ntp_customizer_button October 21, 2024 15:16
@shakyShane shakyShane mentioned this pull request Oct 21, 2024
Merged
8 tasks
@shakyShane shakyShane marked this pull request as ready for review October 21, 2024 15:43
@shakyShane shakyShane requested review from mgurgel and a team as code owners October 21, 2024 15:43
@shakyShane shakyShane marked this pull request as draft October 21, 2024 15:44
@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 2b9dfc0
🔍 Latest deploy log https://app.netlify.com/sites/content-scope-scripts/deploys/6728fc8317e19c000878e6e8
😎 Deploy Preview https://deploy-preview-1150--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from 91e2b7f to 0465631 Compare October 23, 2024 11:59
Base automatically changed from 10-21-ntp_customizer_button to main October 23, 2024 18:47
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 4 times, most recently from 25a52ba to 76952de Compare October 26, 2024 16:13
@shakyShane shakyShane changed the base branch from main to 10-29-ntp_update_notification October 31, 2024 21:14
@shakyShane shakyShane mentioned this pull request Oct 31, 2024
Merged
10 tasks
Base automatically changed from 10-29-ntp_update_notification to main November 1, 2024 13:16
@shakyShane shakyShane changed the base branch from 10-29-updating_playwright to extract_entry_points November 2, 2024 14:03
@shakyShane shakyShane mentioned this pull request Nov 2, 2024
Merged
9 tasks
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 2 times, most recently from 88a918b to 8b663a3 Compare November 2, 2024 14:28
@shakyShane shakyShane force-pushed the favorites_drag_and_drop branch 5 times, most recently from 1441c2d to 84c92f6 Compare November 4, 2024 09:52
@shakyShane shakyShane mentioned this pull request Nov 4, 2024
Merged
8 tasks
@shakyShane shakyShane changed the base branch from extract_entry_points to ntp_add_pragmatic-drag-and-drop November 4, 2024 09:52
@shakyShane shakyShane mentioned this pull request Nov 4, 2024
Open
8 tasks
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from d0a9f9a to a44ac85 Compare November 4, 2024 10:26
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from a44ac85 to fcc0450 Compare November 4, 2024 14:07
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from fcc0450 to a5d163f Compare November 4, 2024 14:35
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from a5d163f to 59d1ced Compare November 4, 2024 14:43
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from 59d1ced to 303d7ad Compare November 4, 2024 14:50
@shakyShane shakyShane force-pushed the ntp_add_pragmatic-drag-and-drop branch from 303d7ad to 41f7d0a Compare November 4, 2024 16:55
@shakyShane shakyShane changed the title favorites drag and drop ntp: favorites drag and drop Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgurgel mgurgel Awaiting requested review from mgurgel mgurgel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shakyShane