Add predicate pushdown (updated)

[mike-luabase]

No description provided.

[Mytherin]

The majority of lines changed here are still formatting changes - could you format using our clang-format config?

[mike-luabase]

@Mytherin fixed the formatting, sorry about that!

[samansmink]

Also @mike-luabase, you don't need to reopen the PR every time, this makes it harder to review actually since we lose a clear view on the review comments that were made before.

If you want to overwrite commits you can just force push to your feature branch

[mike-luabase]

Also @mike-luabase, you don't need to reopen the PR every time, this makes it harder to review actually since we lose a clear view on the review comments that were made before.

Yes, understood, won't do that again.

[mike-luabase]

This test is failing, looking into it

SELECT count(*) FROM ICEBERG_SCAN('data/iceberg/generated_spec2_0_001/pyspark_iceberg_table');
Lower bounds is null
Upper bounds is null
Binder Error: Table "iceberg_scan_data" does not have a column named "filename"

[mike-luabase]

@Mytherin test failure should be fixed now

[mike-luabase]

@samansmink @Mytherin can we trigger the run again? This error doesn't seem related to my changes:

#7 [ 3/14] RUN apt-get install -y -qq software-properties-common
#7 0.232 E: Unable to locate package software-properties-common
#7 ERROR: process "/bin/sh -c apt-get install -y -qq software-properties-common" did not complete successfully: exit code: 100
------
 > [ 3/14] RUN apt-get install -y -qq software-properties-common:
0.232 E: Unable to locate package software-properties-common
------
Dockerfile:9
--------------------
   7 |     # Setup the basic necessities
   8 |     RUN apt-get update -y -qq
   9 | >>> RUN apt-get install -y -qq software-properties-common
  10 |     RUN apt-get install -y -qq --fix-missing ninja-build make gcc-multilib g++-multilib libssl-dev wget openjdk-8-jdk zip maven unixodbc-dev libc6-dev-i386 lib32readline6-dev libssl-dev libcurl4-gnutls-dev libexpat1-dev gettext unzip build-essential checkinstall libffi-dev curl libz-dev openssh-client pkg-config autoconf
  11 |     RUN apt-get install -y -qq ccache
--------------------
ERROR: failed to solve: process "/bin/sh -c apt-get install -y -qq software-properties-common" did not complete successfully: exit code: 100

[catkins]

@mike-luabase 💚 I'm so excited to see movement on this! I'll be able to delete a bunch of manual partition pruning + read_parquet code in an app of mine!

[mike-luabase]

@samansmink anything I can do to help here?

[samansmink]

If you could re-add a PR description and address @Mytherin's comment from one of your previous PRs #75 (comment), I will take a more detailed look to review this.

Please be considerate that reviews take a lot of time, especially reviews from outside contributors that are touching complicated code. To get your PRs through as quick as possible, I recommend you to:

• double check your ideas for a PR with a core contributor of DuckDB through either the DuckDB discord channel, a github issue or a github discussion. See (https://github.com/duckdb/duckdb/blob/main/CONTRIBUTING.md)
• Make sure that your PRs are easy to review
  • no big PRs
  • don't add big format changes to your PRs
  • write a clear description of what you are adding and why you chose the path you chose