Merge pull request lidofinance#261 from lidofinance/fix/critical-miss…

…ed-proposes-alert fix: bug in Critical Missed Proposes alert
dsrvlabs · Oct 22, 2024 · d189814 · d189814
2 parents 8e5d225 + 81b76a3
commit d189814
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/common/alertmanager/alerts/CriticalMissedProposes.ts b/src/common/alertmanager/alerts/CriticalMissedProposes.ts
@@ -40,8 +40,10 @@ export class CriticalMissedProposes extends Alert {
       for (const [operator, operatorResult] of Object.entries(ruleResult)) {
         const prevAll = sentAlerts[this.alertname]?.ruleResult[operator]?.all ?? 0;
         const prevMissed = sentAlerts[this.alertname]?.ruleResult[operator]?.missed ?? 0;
+        const prevMissedShare = prevAll === 0 ? 0 : prevMissed / prevAll;
+
         // if math relation of missed to all increased
-        if (operatorResult.missed / operatorResult.all > prevMissed / prevAll && this.sendTimestamp - prevSendTimestamp > defaultInterval)
+        if (operatorResult.missed / operatorResult.all > prevMissedShare && this.sendTimestamp - prevSendTimestamp > defaultInterval)
           return true;
       }
     }