Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed BigDecimal warning #465

Merged
merged 2 commits into from
Jan 5, 2024
Merged

Fixed BigDecimal warning #465

merged 2 commits into from
Jan 5, 2024

Conversation

bkuhlmann
Copy link
Contributor

@bkuhlmann bkuhlmann commented Jan 4, 2024

Overview

The following ensures BigDecimal is required in the gemspec so warnings are resolved when using Ruby 3.3.0. This is backward compatible for all supported Ruby versions of this project.

Details

Resolves #464.

Necessary to prevent the following Ruby warning showing up when using this gem: "bigdecimal was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add bigdecimal to your Gemfile or gemspec. Also contact author of zeitwerk-2.6.12 to add bigdecimal into its gemspec."

Issue: 464
Milestone: patch
Tracker: github
Necessary to publish new version.

Issue: 464
Milestone: patch
Tracker: github
@timriley timriley merged commit d2c37a6 into dry-rb:main Jan 5, 2024
5 checks passed
@bkuhlmann bkuhlmann deleted the big_decimal branch January 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BigDemical warning
2 participants