Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix gconfig env parsing #17

Merged
merged 4 commits into from
Sep 30, 2023
Merged

fix gconfig env parsing #17

merged 4 commits into from
Sep 30, 2023

Conversation

drshriveer
Copy link
Owner

Background

→ turns out I never tested (and thus never fixed) environment / flag parsing. this pr does that.

Changes

  • fix flag parsing bug
  • also parse from environment variables
  • update readme

Testing

  • added related tests

@drshriveer drshriveer merged commit cb32961 into main Sep 30, 2023
3 checks passed
@drshriveer drshriveer deleted the gs/fix-gconfig-env-parsing branch September 30, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant