Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unstable gsort ordering and release fixes #12

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

drshriveer
Copy link
Owner

Background

→ gsort with multiple types in the same file had inconsistent ordering of generated code. this pr aims to fix it while also trying to fix semantic-releases.

Changes

  • gsort:
    • sort the gsort types before writing
    • return error if no gsort annotations provided
  • golint
    • disable loop closure because of GOEXPERIMENT loopier
  • add .goreleaser.yaml file

Testing

  • existing tests mostly, but added a few more

@drshriveer drshriveer merged commit c0c6e4c into main Sep 22, 2023
3 checks passed
@drshriveer drshriveer deleted the gs/fix-unstable-gensort branch September 22, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant