Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to objc sdk reserved word list #351

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

julianlocke
Copy link
Contributor

@julianlocke julianlocke commented Sep 30, 2024

Expanding the route allow list for the migration shim exposes more naming collisions. This PR adds a few more names to the reserved name list. Names on this list are suffixed with _ to avoid the collisions.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@julianlocke julianlocke changed the title [WIP] Add to objc sdk reserved word list Add to objc sdk reserved word list Sep 30, 2024
@julianlocke julianlocke merged commit 6991769 into main Oct 24, 2024
10 checks passed
@julianlocke julianlocke deleted the objc-shim-objc-changes branch October 24, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants