Optimize memory usage.

Dropbox.Api.Tests/DropboxApiTests.cs

@@ -249,6 +249,22 @@ public async Task TestNoAuth()
             Assert.IsTrue(response.Changes);
         }
 
+        /// Test APM flow.
+        /// </summary>
+        [TestMethod]
+        public void TaskAPM()
+        {
+            var result = Client.Users.BeginGetCurrentAccount(null);
+            var account = Client.Users.EndGetCurrentAccount(result);
+            var accountId = account.AccountId;
+
+            result = Client.Users.BeginGetAccountBatch(new string[] { accountId }, null);
+            var accounts = Client.Users.EndGetAccountBatch(result);
+
+            Assert.AreEqual(accounts.Count, 1);
+            Assert.AreEqual(accounts[0].AccountId, accountId);
+        }
+
         /// <summary>
         /// Converts string to a memory stream.
         /// </summary>

Dropbox.Api/Async/PollArg.cs

@@ -51,6 +51,7 @@ public PollArg(string asyncJobId)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PollArg()
         {
         }

Dropbox.Api/Auth/RateLimitError.cs

@@ -50,6 +50,7 @@ public RateLimitError(RateLimitReason reason,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public RateLimitError()
         {
             this.RetryAfter = 1;

Dropbox.Api/Auth/TokenFromOAuth1Arg.cs

@@ -65,6 +65,7 @@ public TokenFromOAuth1Arg(string oauth1Token,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public TokenFromOAuth1Arg()
         {
         }

Dropbox.Api/Auth/TokenFromOAuth1Result.cs

@@ -53,6 +53,7 @@ public TokenFromOAuth1Result(string oauth2Token)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public TokenFromOAuth1Result()
         {
         }

Dropbox.Api/DropboxRequestHandler.cs

@@ -243,12 +243,21 @@ private async Task<Result> RequestJsonStringWithRetry(
 
             if (routeStyle == RouteStyle.Upload)
             {
+                if (body == null)
+                {
+                    throw new ArgumentNullException("body");
+                }
+
                 // to support retry logic, the body stream must be seekable
                 // if it isn't we won't retry
                 if (!body.CanSeek)
                 {
                     maxRetries = 0;
                 }
+                else if (maxRetries == 0)
+                {
+                    // Do not copy the stream
+                }
                 else if (body is MemoryStream)
                 {
                     cachedStreamStart = body.Position;
@@ -565,7 +574,6 @@ private class Result
         /// </summary>
         /// <typeparam name="TResponse">The type of the response.</typeparam>
         private class DownloadResponse<TResponse> : IDownloadResponse<TResponse>
-            where TResponse : new()
         {
             /// <summary>
             /// The HTTP response containing the body content.

Dropbox.Api/Files/AlphaGetMetadataArg.cs

@@ -63,6 +63,7 @@ public AlphaGetMetadataArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public AlphaGetMetadataArg()
         {
         }

Dropbox.Api/Files/CommitInfo.cs

@@ -77,6 +77,7 @@ public CommitInfo(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CommitInfo()
         {
             this.Mode = Dropbox.Api.Files.WriteMode.Add.Instance;

Dropbox.Api/Files/CommitInfoWithProperties.cs

@@ -66,6 +66,7 @@ public CommitInfoWithProperties(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CommitInfoWithProperties()
         {
         }

Dropbox.Api/Files/CreateFolderArg.cs

@@ -56,6 +56,7 @@ public CreateFolderArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public CreateFolderArg()
         {
             this.Autorename = false;

Dropbox.Api/Files/DeleteArg.cs

@@ -50,6 +50,7 @@ public DeleteArg(string path)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DeleteArg()
         {
         }

Dropbox.Api/Files/DeleteBatchArg.cs

@@ -48,6 +48,7 @@ public DeleteBatchArg(col.IEnumerable<DeleteArg> entries)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DeleteBatchArg()
         {
         }

Dropbox.Api/Files/DeleteBatchResult.cs

@@ -50,6 +50,7 @@ public DeleteBatchResult(col.IEnumerable<DeleteBatchResultEntry> entries)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DeleteBatchResult()
         {
         }

Dropbox.Api/Files/DeleteResult.cs

@@ -46,6 +46,7 @@ public DeleteResult(Metadata metadata)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DeleteResult()
         {
         }

Dropbox.Api/Files/DeletedMetadata.cs

@@ -62,6 +62,7 @@ public DeletedMetadata(string name,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DeletedMetadata()
         {
         }

Dropbox.Api/Files/Dimensions.cs

@@ -44,6 +44,7 @@ public Dimensions(ulong height,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public Dimensions()
         {
         }

Dropbox.Api/Files/DownloadArg.cs

@@ -66,6 +66,7 @@ public DownloadArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public DownloadArg()
         {
         }

Dropbox.Api/Files/FileMetadata.cs

@@ -126,6 +126,7 @@ public FileMetadata(string name,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public FileMetadata()
         {
         }

Dropbox.Api/Files/FileSharingInfo.cs

@@ -74,6 +74,7 @@ public FileSharingInfo(bool readOnly,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public FileSharingInfo()
         {
         }

Dropbox.Api/Files/FolderMetadata.cs

@@ -93,6 +93,7 @@ public FolderMetadata(string name,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public FolderMetadata()
         {
         }

Dropbox.Api/Files/FolderSharingInfo.cs

@@ -80,6 +80,7 @@ public FolderSharingInfo(bool readOnly,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public FolderSharingInfo()
         {
             this.TraverseOnly = false;

Dropbox.Api/Files/GetCopyReferenceArg.cs

@@ -53,6 +53,7 @@ public GetCopyReferenceArg(string path)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GetCopyReferenceArg()
         {
         }

Dropbox.Api/Files/GetCopyReferenceResult.cs

@@ -61,6 +61,7 @@ public GetCopyReferenceResult(Metadata metadata,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GetCopyReferenceResult()
         {
         }

Dropbox.Api/Files/GetMetadataArg.cs

@@ -66,6 +66,7 @@ public GetMetadataArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GetMetadataArg()
         {
             this.IncludeMediaInfo = false;

Dropbox.Api/Files/GetTemporaryLinkArg.cs

@@ -52,6 +52,7 @@ public GetTemporaryLinkArg(string path)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GetTemporaryLinkArg()
         {
         }

Dropbox.Api/Files/GetTemporaryLinkResult.cs

@@ -57,6 +57,7 @@ public GetTemporaryLinkResult(FileMetadata metadata,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GetTemporaryLinkResult()
         {
         }

Dropbox.Api/Files/GpsCoordinates.cs

@@ -44,6 +44,7 @@ public GpsCoordinates(double latitude,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public GpsCoordinates()
         {
         }

Dropbox.Api/Files/ListFolderArg.cs

@@ -69,6 +69,7 @@ public ListFolderArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderArg()
         {
             this.Recursive = false;

Dropbox.Api/Files/ListFolderContinueArg.cs

@@ -54,6 +54,7 @@ public ListFolderContinueArg(string cursor)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderContinueArg()
         {
         }

Dropbox.Api/Files/ListFolderGetLatestCursorResult.cs

@@ -54,6 +54,7 @@ public ListFolderGetLatestCursorResult(string cursor)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderGetLatestCursorResult()
         {
         }

Dropbox.Api/Files/ListFolderLongpollArg.cs

@@ -71,6 +71,7 @@ public ListFolderLongpollArg(string cursor,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderLongpollArg()
         {
             this.Timeout = 30;

Dropbox.Api/Files/ListFolderLongpollResult.cs

@@ -51,6 +51,7 @@ public ListFolderLongpollResult(bool changes,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderLongpollResult()
         {
         }

Dropbox.Api/Files/ListFolderResult.cs

@@ -70,6 +70,7 @@ public ListFolderResult(col.IEnumerable<Metadata> entries,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListFolderResult()
         {
         }

Dropbox.Api/Files/ListRevisionsArg.cs

@@ -64,6 +64,7 @@ public ListRevisionsArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListRevisionsArg()
         {
             this.Limit = 10;

Dropbox.Api/Files/ListRevisionsResult.cs

@@ -54,6 +54,7 @@ public ListRevisionsResult(bool isDeleted,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public ListRevisionsResult()
         {
         }

Dropbox.Api/Files/MediaMetadata.cs

@@ -49,6 +49,7 @@ protected MediaMetadata(Dimensions dimensions = null,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public MediaMetadata()
         {
         }

Dropbox.Api/Files/Metadata.cs

@@ -82,6 +82,7 @@ protected Metadata(string name,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public Metadata()
         {
         }

Dropbox.Api/Files/PathRootError.cs

@@ -42,6 +42,7 @@ public PathRootError(string pathRoot = null)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PathRootError()
         {
         }

Dropbox.Api/Files/PhotoMetadata.cs

@@ -46,6 +46,7 @@ public PhotoMetadata(Dimensions dimensions = null,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PhotoMetadata()
         {
         }

Dropbox.Api/Files/PreviewArg.cs

@@ -66,6 +66,7 @@ public PreviewArg(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PreviewArg()
         {
         }

Dropbox.Api/Files/PropertyGroupUpdate.cs

@@ -69,6 +69,7 @@ public PropertyGroupUpdate(string templateId,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PropertyGroupUpdate()
         {
         }

Dropbox.Api/Files/PropertyGroupWithPath.cs

@@ -63,6 +63,7 @@ public PropertyGroupWithPath(string path,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public PropertyGroupWithPath()
         {
         }

Dropbox.Api/Files/RelocationArg.cs

@@ -56,6 +56,7 @@ public RelocationArg(string fromPath,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public RelocationArg()
         {
             this.AllowSharedFolder = false;

Dropbox.Api/Files/RelocationBatchArg.cs

@@ -64,6 +64,7 @@ public RelocationBatchArg(col.IEnumerable<RelocationPath> entries,
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public RelocationBatchArg()
         {
             this.AllowSharedFolder = false;

Dropbox.Api/Files/RelocationBatchResult.cs

@@ -50,6 +50,7 @@ public RelocationBatchResult(col.IEnumerable<RelocationResult> entries)
         /// </summary>
         /// <remarks>This is to construct an instance of the object when
         /// deserializing.</remarks>
+        [sys.ComponentModel.EditorBrowsable(sys.ComponentModel.EditorBrowsableState.Never)]
         public RelocationBatchResult()
         {
         }