Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FileIcon): missing svg widht/height #4483

Merged
merged 2 commits into from
Oct 18, 2024
Merged

fix(FileIcon): missing svg widht/height #4483

merged 2 commits into from
Oct 18, 2024

Conversation

ArgoZhang
Copy link
Collaborator

missing svg widht/height

Summary of the changes (Less than 80 chars)

简单描述你更改了什么, 不超过80个字符;如果有关联 Issue 请在下方填写相关编号

Description

fixes #4482

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

[是否影响老版本]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

@bb-auto bb-auto bot added the bug Something isn't working label Oct 18, 2024
@bb-auto bb-auto bot added this to the v8.10.0 milestone Oct 18, 2024
@ArgoZhang ArgoZhang merged commit fdd92e1 into main Oct 18, 2024
3 checks passed
@ArgoZhang ArgoZhang deleted the fix-icon branch October 18, 2024 02:14
Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (5af54c7) to head (32e9275).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #4483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          613       613           
  Lines        26618     26618           
  Branches      3880      3880           
=========================================
  Hits         26618     26618           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(FileIcon): missing svg widht/height
1 participant