More from kernel32 & advapi32

[vbfox]

Added :

• AdvApi32.OpenProcessToken
• AdvApi32.GetTokenInformation
• AdvApi32.QueryServiceObjectSecurity
• AdvApi32.SetServiceObjectSecurity
• Kernel32.GetConsoleWindow
• Kernel32.LoadLibrary
• Kernel32.FreeLibrary

[jmelosegui]

here should be TokenAccessRights

[vbfox]

Thanks, fixed.

[jmelosegui]

@vbfox it is not clear to me whether should we decorate a boolean return value with
[return: MarshalAs(UnmanagedType.Bool)] or not. Could you please expand on this?

[vbfox]

@jmelosegui It isn't mandatory as it is the default value for PInvoke but it's what one of the FxCop rules (CA1414) mandate, we started to discuss it on #50.

It's still unknown if we will apply it but i'm for enabling all the rules that make sense. The reason for this rule is that the default value is the Win32 vision of what a boolean is (32-bits value with 0 meaning false and anything else meaning true) but not all platforms (or even libraries under windows) conform to that so it's clearer to specify what is meant by "bool" (Even if the enum member name isn't clear it's documentation summary is really clear on what it is)

[jmelosegui]

Clear now, thanks!!!

[AArnott]

double-checking that naturally occurring +1's for each of these values coincide with their native equivalents?

[vbfox]

For once it's actually defined as a real enum in native code : https://msdn.microsoft.com/en-us/library/windows/desktop/aa379626(v=vs.85).aspx with the same value generation

[AArnott]

LGTM, after comments