Always respect warning-as-error properties #10892
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remote (built in another node) projects were not respecting MSBuildWarningsNotAsErrors configured in the projects, when the API or CLI `-warnaserror` option was enabled. Fixes dotnet#10874.
JanKrivanek
reviewed
Oct 27, 2024
| // If this is BuildCheck-ed build - add the warnings promotability/demotability to the service | ||
| if (buildEventArgs is ProjectStartedEventArgs projectStartedEvent && this._componentHost.BuildParameters.IsBuildCheckEnabled) | ||
| // Respect warning-promotion properties from the remote project | ||
| if (buildEventArgs is ProjectStartedEventArgs projectStartedEvent) |
There was a problem hiding this comment.
It'll need the worker node side adjust as well:
Hopefuly it shouldn't have significant perf impact - but I haven't test that as it was limited to BuildCheck that's perf hit anyways.
There was a problem hiding this comment.
I don't think I understand why that needs to change. This does fix the basic issue in #10874.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote (built in another node) projects were not respecting MSBuildWarningsNotAsErrors configured in the projects, when the API or CLI
-warnaserroroption was enabled.Fixes #10874.