Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead code from nativemethods #10840

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

kasperk81
Copy link
Contributor

followup on #9223

@JanKrivanek
Copy link
Member

Hello @kasperk81 - thank you for your contribution! MSBuild team for sure appraciates contributions. Upfront heads up via bug or other form of discussion is preferred (plus an explicit confirmation of wanting to fix).

More details: https://github.com/dotnet/msbuild/blob/main/documentation/wiki/Contributing-Code.md

Each PR should ideally have motivation and goal in the description (links are big advantage, but important context should be part of the PR).

By no means would I want to kill the interest and flow :-) But it should be just little extra work that will save us considerable time.


In this specific PR - it mentiones it's a followup of the other PR that uses IO.Redist on NetFx, while here only single implementation is used - it's bit confusing to me. It looks great as code cleanup. Though as mentioned followup I'd expect the usage of IO.Redist or justification why not using it

@kasperk81
Copy link
Contributor Author

while here only single implementation is used

the change in WindowsFileSystem.cs is following the other pr, MSBuildTaskHostFileSystem.cs is only built on netfx so it didn't required netcore tfm branch and that's the only difference there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants