.slnx support - use the new parser for .sln and .slnx #10836
+912
−1,237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit suggestions Co-authored-by: Rainer Sigwald <[email protected]> Co-authored-by: Jan Krivanek <[email protected]>
… Solution_OldParser_Tests
kasperk81
reviewed
Oct 17, 2024
|
lets see what happens if we now merge main (fingers crossed) :) |
|
the one failing test |
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Oct 24, 2024
This should help identify failures like dotnet#10836 (comment).
|
Diagnosability on that test is quite unfortunate, but hopefully fixable (#10886). |
kasperk81
reviewed
Oct 25, 2024
Co-authored-by: kasperk81 <[email protected]>
Merged
rainersigwald
approved these changes
Oct 25, 2024
src/Build.UnitTests/Construction/SolutionProjectGenerator_Tests.cs
Outdated
Show resolved
Hide resolved
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Oct 25, 2024
This should help identify failures like dotnet#10836 (comment).
Co-authored-by: Rainer Sigwald <[email protected]>
Co-authored-by: Rainer Sigwald <[email protected]>
…/msbuild into slnx-support-followup
surayya-MS
commented
Oct 28, 2024
eng/Versions.props
Outdated
Comment on lines
5
to
6
| <VersionPrefix>17.14.0</VersionPrefix> | ||
| <PackageValidationBaselineVersion>17.12.0</PackageValidationBaselineVersion> |
There was a problem hiding this comment.
@rainersigwald do you know if we should also update PackageValidationBaselineVersion?
kasperk81
reviewed
Oct 28, 2024
rainersigwald
requested changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The .slnx support PR is split in 2 - 1. use new parser for .slnx, 2. use new parser for both .sln (under change wave) and .slnx. This is the follow-up PR.
Changes Made
Microsoft.VisualStudio.SolutionPersistenceparser to parse .slnx and .sln (applied 17.13 change wave for .sln)Testing
Moved tests from
SolutionFile_Teststhat are old parser specific to theSolutionFile_OldParser_Tests.Some of them already had duplicates there:
BadVersionStamp,VersionTooLow,ParseSolutionFileWithDescriptionInformation,MissingNestedProject,ParseInvalidSolutionConfigurations1,ParseInvalidSolutionConfigurations2,ParseInvalidSolutionConfigurations3.Deleted
SolutionFile_Tests.SharedProjectstest because it just checks dependencies and we already have test for that. It also has "GlobalSection(SharedMSBuildProjectFiles)" section but we do not parse it in the old parser.Changed
SolutionProjectGeneratorTests- refactored strings and used both old and new parsers in the tests (except where only the old one can be used, made a remark there about it)Deleted
GraphConstructionShouldThrowOnMissingSolutionDependenciestest because it checks specifics of how solution projects' dependencies were parsed. "SolutionParseProjectDepNotFoundError" is thrown when the project dependency does not exist. And this is handled differently in the new parser - the dependency is not added at all if it did not exist in solution.