Use CallerArgumentExpression for internal assert-like constructs #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But don't use it anywhere yet.
Includes some nullability adjustments to work with the new paradigm.
JanKrivanek
approved these changes
Oct 20, 2024
| @@ -467,7 +468,7 @@ internal static void VerifyThrowArgument([DoesNotReturnIf(false)] bool condition | |||
| /// Throws an argument out of range exception. | |||
| /// </summary> | |||
| [DoesNotReturn] | |||
| internal static void ThrowArgumentOutOfRange(string parameterName) | |||
| internal static void ThrowArgumentOutOfRange(string? parameterName) | |||
There was a problem hiding this comment.
Why is this needed? - I'd expect this change to not cause weaker nullability guarantee
There was a problem hiding this comment.
Yeah this is a bit unfortunate. To use [CallerMemberName] you have to provide a default value, and the one for string parameterName that makes the most sense IMO is null. But then there's a possibility that null flows through the other overload of ThrowArgumentOutOfRange to here.
I think I prefer this to swapping it for "" but if you feel strongly the other way I can swap it. Definitely not a strong preference on my side.
maridematte
approved these changes
Oct 23, 2024
rainersigwald
force-pushed
the
callerargumentexpression
branch
from
a1017ea
to
96592c8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
From ``` ErrorUtilities\.VerifyThrowArgumentNull\(([a-zA-Z0-9]+), nameof\(\1\)\); ``` to ``` ErrorUtilities.VerifyThrowArgumentNull($1); ``` (And then revert `src/Deprecated`.)
From ``` ErrorUtilities\.VerifyThrowArgumentLength\(([a-zA-Z0-9]+), nameof\(\1\)\); ``` to ``` ErrorUtilities.VerifyThrowArgumentLength($1); ``` And revert `src/Deprecated`.
From ``` ErrorUtilities\.VerifyThrowInternalNull\(([a-zA-Z0-9]+), nameof\(\1\)\); ``` to ``` ErrorUtilities.VerifyThrowInternalNull($1); ``` and revert `src/Deprecated`.
rainersigwald
force-pushed
the
callerargumentexpression
branch
from
96592c8
to
5b7ef3c
Compare
on macOS??? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CallerArgumentExpressionis a new (C# 10) language feature that allows us to simplify a bunch of our assert-like code to drop the redundant specifications of, like, "which argument isnull?".I strongly recommend reviewing commit-by-commit; the bulk of the changes are a regex replace on top of a framework that is fairly small.